Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Metric forward to use only a single update call #141

Closed

Conversation

janvainer
Copy link

Refactor Metric forward to use only a single update call. #126

@Borda
Copy link
Member

Borda commented Apr 13, 2021

@janvainer how is it going here? any progress or need a hand? 🐰

@janvainer
Copy link
Author

Hi @Borda, I am waiting for more inputs on the API changes that would be required to make this PR work. Please check this issue. Once the API changes are clear and approved, I will rework the PR.

@Borda Borda requested a review from SkafteNicki April 13, 2021 16:04
@Borda Borda added enhancement New feature or request refactoring refactoring and code health labels Apr 13, 2021
@Borda Borda requested a review from justusschock April 13, 2021 16:05
@Borda
Copy link
Member

Borda commented Apr 18, 2021

@PyTorchLightning/core-metrics mind share your opinion on the API?

@SkafteNicki
Copy link
Member

Closing. See comment #126 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants